Warn when Koanf read fails #47

Hunman · 2022-12-30T01:46:34Z

Hunman commented

2022-12-30 01:46:34 +00:00

Figured out the problem in issue #32, the toml file syntax was invalid (I had ' instead of " at some values), but there was nothing in the logs about it.

Moved the config reading (and watching) into the same function, which logs the error as a warning.

I wanted to try moving the whole if into a separate function, but I kept getting errors when I tried to extract the path from the File, so I have that attempt in a separate branch not in this pull request: 5a84bf8148

Figured out the problem in issue #32, the toml file syntax was invalid (I had `'` instead of `"` at some values), but there was nothing in the logs about it. Moved the config reading (and watching) into the same function, which logs the error as a warning. I wanted to try moving the whole `if` into a separate function, but I kept getting errors when I tried to extract the `path` from the `File`, so I have that attempt in a separate branch not in this pull request: https://gitea.arsenm.dev/Hunman/itd/commit/5a84bf81489d3dc57f197f5feef5521950645ba5

Hunman added 2 commits 2022-12-30 01:46:35 +00:00

82bb145cbc Move the global config path into a variable

ci/woodpecker/pr/woodpecker Pipeline was successful Details

a254762288 Load the configs in one function, which handles the error too

We are doing the same thing to global and user level config, so it makes
sense to do it in a separate function
Loaded in the fmt package, so we can print out everything in one useful
error (actually warning) message

Elara6331 requested changes 2023-01-02 03:01:06 +00:00

Elara6331 left a comment

Other than these two minor changes, it looks good, thanks!

config.go

						
				@ -71,0 +68,4 @@

					provider := file.Provider(filename)

					if cfgError := k.Load(provider, toml.Parser()); cfgError != nil {

						log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error()))

Elara6331 commented

2023-01-02 02:59:28 +00:00

- log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error()))
+ log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file")

```diff - log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error())) + log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file") ```

Hunman marked this conversation as resolved

config.go

						
				@ -76,2 +79,3 @@

						k.Load(provider, toml.Parser())

						if cfgError := k.Load(provider, toml.Parser()); cfgError != nil {

							log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error()))

Elara6331 commented

2023-01-02 03:00:06 +00:00

Same as above

- log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error()))
+ log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file")

Same as above ```diff - log.Warn().Msg(fmt.Sprintf("Error while trying to read %s: %s\n", filename, cfgError.Error())) + log.Warn().Str("filename", filename).Err(cfgError).Msg("Error while trying to read config file") ```

Hunman marked this conversation as resolved

Hunman added 1 commit 2023-01-02 08:59:57 +00:00