Move mpris implementation from infinitime library to itd, where it really belongs #41

Merged
Arsen6331 merged 2 commits from FloralExMachina/itd:master into master 2 months ago

This PR Copys the Mpris implementation from the infinitime library and on acceptance a follow up PR to the infinitime library will remove the implementation there. The justification for this is that the library's purpose is facilitating the transmission and reception of events between a device and host, the onus is on the user of the library to take actions on recieved events. This is already reflected with the desktop notification relay, call relay, and maps, This also opens up future support for (white|black) listing players to avoid misbehaving implementors e.g chromium (and browsers based on it) or disabling the use of mpris altogether via the config, in favour listening for music button events with itctl

This PR Copys the Mpris implementation from the infinitime library and on acceptance a follow up PR to the infinitime library will remove the implementation there. The justification for this is that the library's purpose is facilitating the transmission and reception of events between a device and host, the onus is on the user of the library to take actions on recieved events. This is already reflected with the desktop notification relay, call relay, and maps, This also opens up future support for (white|black) listing players to avoid misbehaving implementors e.g [chromium](https://bugs.chromium.org/p/chromium/issues/detail?id=1101966&q=mpris&can=2) (and browsers based on it) or disabling the use of mpris altogether via the config, in favour listening for music button events with itctl
FloralExMachina added 1 commit 2 months ago
ci/woodpecker/pr/woodpecker Pipeline was successful Details
1e8c9484d2
copy mpris implementation from infinitime library to itd, where it really belongs
Arsen6331 requested changes 2 months ago
onChangeOnce sync.Once
)
// Init makes required connections to DBis and
Owner

There's a typo here. Should be DBus, not DBis

There's a typo here. Should be `DBus`, not `DBis`
Owner

Other than that, it seems good to me. I probably should've placed that in ITD in the first place, I was meaning to move it eventually but never got around to it and then forgot. Thanks for the PR.

Other than that, it seems good to me. I probably should've placed that in ITD in the first place, I was meaning to move it eventually but never got around to it and then forgot. Thanks for the PR.
FloralExMachina added 1 commit 2 months ago
ci/woodpecker/pr/woodpecker Pipeline was successful Details
f215e4fd90
fixed type in comment about DBus
FloralExMachina requested review from Arsen6331 2 months ago
Poster

fixed :)

fixed :)
Arsen6331 approved these changes 2 months ago
Arsen6331 left a comment
Owner

Thanks, merging now

Thanks, merging now
Arsen6331 merged commit b64e6d27d4 into master 2 months ago

Reviewers

Arsen6331 approved these changes 2 months ago
ci/woodpecker/pr/woodpecker Pipeline was successful
The pull request has been merged as b64e6d27d4.
Sign in to join this conversation.
Loading…
There is no content yet.