Move mpris implementation from infinitime library to itd, where it really belongs #41
Merged
Arsen6331
merged 2 commits from FloralExMachina/itd:master
into master
2 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'FloralExMachina/itd:master'
Deleting a branch is permanent. It CANNOT be undone. Continue?
This PR Copys the Mpris implementation from the infinitime library and on acceptance a follow up PR to the infinitime library will remove the implementation there. The justification for this is that the library's purpose is facilitating the transmission and reception of events between a device and host, the onus is on the user of the library to take actions on recieved events. This is already reflected with the desktop notification relay, call relay, and maps, This also opens up future support for (white|black) listing players to avoid misbehaving implementors e.g chromium (and browsers based on it) or disabling the use of mpris altogether via the config, in favour listening for music button events with itctl
onChangeOnce sync.Once
)
// Init makes required connections to DBis and
There's a typo here. Should be
DBus
, notDBis
Other than that, it seems good to me. I probably should've placed that in ITD in the first place, I was meaning to move it eventually but never got around to it and then forgot. Thanks for the PR.
fixed :)
Thanks, merging now
b64e6d27d4
into master 2 months agoReviewers
b64e6d27d4
.