replace pactl based volume control with mpris based volume control #6

Merged
Arsen6331 merged 2 commits from FloralExMachina/infinitime:master into master 2 weeks ago

Currently, the infinitime library relys on external commands for volume control with music, this has the pro of allowing the user to control the general volume of the device currently bound to the watch, however without more complex commands this falls short if the user has multiple pulseaudio sinks or does not use pulseaudio. This is also an inconsistancy in design, the InfiniTime firmware expose volume control within the Music control app, and itd exposes the volume control interval in its config as a property of the music player, in my opinion a user would expect these control to only affect the volume of music, not the system volume. This PR attempts to correct these issues by changing volume control to use the MPRIS player volume property.

An alternative solution, would be to move music controls into itd, and allow the user to provide commands within the itd config on music event.

Currently, the infinitime library relys on external commands for volume control with music, this has the pro of allowing the user to control the general volume of the device currently bound to the watch, however without more complex commands this falls short if the user has multiple pulseaudio sinks or does not use pulseaudio. This is also an inconsistancy in design, the InfiniTime firmware expose volume control within the Music control app, and itd exposes the volume control interval in its config as a property of the music player, in my opinion a user would expect these control to only affect the volume of music, not the system volume. This PR attempts to correct these issues by changing volume control to use the MPRIS player volume property. An alternative solution, would be to move music controls into itd, and allow the user to provide commands within the itd config on music event.
FloralExMachina added 1 commit 2 weeks ago
Owner

This is a good idea, thanks. Can you also update the README and remove the pulseaudio-utils and libpulse dependencies? Thank you.

This is a good idea, thanks. Can you also update the README and remove the `pulseaudio-utils` and `libpulse` dependencies? Thank you.
FloralExMachina added 1 commit 2 weeks ago
Poster

done :)

done :)
Owner

Thanks, merging now

Thanks, merging now
Arsen6331 merged commit 0c369dc5df into master 2 weeks ago
The pull request has been merged as 0c369dc5df.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Arsen6331/infinitime#6
Loading…
There is no content yet.